-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Finalize v0.13.1 #2554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalize v0.13.1 #2554
Conversation
Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
Test output is the cleanest it's been in a while. Docs build is also clean except for a few missing glossary items (ping @RDaxini):
Of course those should be fixed, but not a blocker for the release IMHO. I'll try out a pre-release to ensure that the new Trusted Publishing arrangement (#2549) works. If all goes well then I'll make the real release. |
My two cents:
Feel free to do whatever you want, this is plain nitpicking. |
oops...
For a nice clean release, I could open a PR for 2) and then for the 0.13.2 release we could get these added to the glossary and reinstate the link. A bit of undo/redo, but I don't think that's a problem just in case 1) takes longer than expected. What do you think? |
Co-Authored-By: Echedey Luis <80125792+echedey-ls@users.noreply.github.com>
Co-Authored-By: RDaxini <143435106+RDaxini@users.noreply.github.com>
Thanks @echedey-ls for those points, and good work finding that missing contributor! @RDaxini I opted to do your option (2) here in this PR for the sake of expediency. |
Thanks @kandersolar! 🎉 |
remote-data
) and Milestone are assigned to the Pull Request and linked Issue.