Skip to content

Conversation

kandersolar
Copy link
Member

  • Closes v0.13.1 release planning #2546
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

@kandersolar kandersolar added this to the v0.13.1 milestone Sep 24, 2025
Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
@kandersolar
Copy link
Member Author

Test output is the cleanest it's been in a while. Docs build is also clean except for a few missing glossary items (ping @RDaxini):

sphinx/source/user_guide/modeling_topics/spectrum.rst:55: WARNING: term not in glossary: 'aod'
sphinx/source/user_guide/modeling_topics/spectrum.rst:63: WARNING: term not in glossary: 'clearsky_index'
sphinx/source/user_guide/modeling_topics/spectrum.rst:67: WARNING: term not in glossary: 'clearsky_index'

Of course those should be fixed, but not a blocker for the release IMHO.

I'll try out a pre-release to ensure that the new Trusted Publishing arrangement (#2549) works. If all goes well then I'll make the real release.

@echedey-ls
Copy link
Contributor

echedey-ls commented Sep 24, 2025

My two cents:

  • Line 10 in current branch states:
    * Rename parameter name ``aparent_azimuth`` to ``solar_azimuth`` in :py:func:`~pvlib.tracking.singleaxis`.
    
    aparent_azimuth should be apparent_azimuth
  • We had a new contributor in 7caf4eb
    This account got deleted, so I leave it up to you whether or not to include him in the list of contributors.
  • I'm hesitant about so many :py:func:`~...` -> especially in Line 9:
    * Deprecate :py:func:`~pvlib.modelchain.get_orientation`. (:pull:`2495`)
    
    There are at least two other implementations (methods pvlib.pvsystem.FixedMount.get_orientation and pvlib.pvsystem.SingleAxisTrackerMount.get_orientation) with the same identifier. I also think that if I, as a user, were reading the changelog, I'd find it useful to know exactly what submodule we are talking about, so if the function name does not ring a bell for me, at least know if the features are being used in my scripts.

Feel free to do whatever you want, this is plain nitpicking.

@RDaxini
Copy link
Member

RDaxini commented Sep 24, 2025

Test output is the cleanest it's been in a while. Docs build is also clean except for a few missing glossary items (ping @RDaxini):

sphinx/source/user_guide/modeling_topics/spectrum.rst:55: WARNING: term not in glossary: 'aod'
sphinx/source/user_guide/modeling_topics/spectrum.rst:63: WARNING: term not in glossary: 'clearsky_index'
sphinx/source/user_guide/modeling_topics/spectrum.rst:67: WARNING: term not in glossary: 'clearsky_index'

Of course those should be fixed, but not a blocker for the release IMHO.

I'll try out a pre-release to ensure that the new Trusted Publishing arrangement (#2549) works. If all goes well then I'll make the real release.

oops...
I understand it wouldn't block the release, but this is an easy fix. Happy to do it today. Two options:

  1. add these to the glossary, but this might take longer while we agree on the wording of definitions
  2. remove :term: for these variables

For a nice clean release, I could open a PR for 2) and then for the 0.13.2 release we could get these added to the glossary and reinstate the link. A bit of undo/redo, but I don't think that's a problem just in case 1) takes longer than expected. What do you think?

kandersolar and others added 2 commits September 24, 2025 12:03
Co-Authored-By: Echedey Luis <80125792+echedey-ls@users.noreply.github.com>
Co-Authored-By: RDaxini <143435106+RDaxini@users.noreply.github.com>
@kandersolar
Copy link
Member Author

Thanks @echedey-ls for those points, and good work finding that missing contributor!

@RDaxini I opted to do your option (2) here in this PR for the sake of expediency.

@kandersolar kandersolar merged commit 6b9476b into pvlib:main Sep 24, 2025
27 checks passed
@kandersolar kandersolar deleted the v0131 branch September 24, 2025 16:37
@RDaxini
Copy link
Member

RDaxini commented Sep 24, 2025

Thanks @kandersolar! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v0.13.1 release planning

4 participants