Skip to content

initial io module prototype #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

initial io module prototype #270

wants to merge 12 commits into from

Conversation

dacoex
Copy link
Contributor

@dacoex dacoex commented Nov 30, 2016

prototype for #261 & #29 (can these issues be merged?)

The data is here:
cd MY-GITHUB-CLONES
git clone https://github.com/dacoex/pvlib_data

@adriesse
Copy link
Member

adriesse commented Dec 1, 2016

Thanks for submitting this. The file maccrad format doesn't look like it was designed for ease of parsing.

I can offer a couple of comments from looking at the file and code:

The header section of the maccrad file looks like it could be of variable length, so you probably don't want to hardcode the 40. The leading # can be used to let read_csv skip the variable header section, but unfortunately the column names would be lost that way too. Is the number of columns always the same? In that case I would suggest using header=None and providing a standard name for each column.

Your dateparser looks like it returns text. Does this produce a datetime index for the dataframe?

I the time zone for the data in the file? "# Time reference: Universal time (UT)" Maybe the dataframe could be localized with this?

@dacoex
Copy link
Contributor Author

dacoex commented Dec 1, 2016

Let's first start with a general feedback regarding design of io module.
I moved all comments related to the actual macc-rad format to #271
(Soda-is changed their website again after these example files were downloaded.)

  • Does the sub-module structure correspond to the intentions discussed in 261 & add a io module #29?
    of the if the file structures correspond
  • Is there anything that shall be changed to facilitate the addition of new file formats?

I will use #271 to finalise the first input format and as we go improve design of the io module

@dacoex dacoex changed the title inital io module prototype initial io module prototype Dec 1, 2016
dacoex added 2 commits December 1, 2016 12:36
responding to comments in pvlib#271
- improved metadata retrieval and location setting
- added better options to output

responding to comments in pvlib#270
- moved some functions to general iotools
@wholmgren
Copy link
Member

Thanks @dacoex. Please remake your macc-rad PR against the new io branch discussed in #272.

@dacoex
Copy link
Contributor Author

dacoex commented Dec 2, 2016

closed in favour of #272

maccrad issue discussion in #271 and related PR in #274

@dacoex dacoex closed this Dec 2, 2016
@dacoex dacoex mentioned this pull request Dec 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants