PEP8 fixups to solarposition.py and spa.py

[alorenzo175]

As requested by @uvchik in #48.

[wholmgren]

@uvchik if this looks good to you then I will merge.

For future reference, my vote is to not worry about trailing whitespace.

[uvchik]

Looks good, but between two references must be line break otherwise all references are shown in one line. If you do so you can also keep the 80 character rule. Check the references in : get_solarposition, spa_c, spa_python and get_sun_rise_set_transit.

If you change the following lines:

    References
    ----------
    [1] I. Reda and A. Andreas, Solar position algorithm for solar radiation applications. Solar Energy, vol. 76, no. 5, pp. 577-589, 2004.
    [2] I. Reda and A. Andreas, Corrigendum to Solar position algorithm for solar radiation applications. Solar Energy, vol. 81, no. 6, p. 838, 2007.
    [3] USNO delta T: http://www.usno.navy.mil/USNO/earth-orientation/eo-products/long-term

to:

    References
    ----------
    [1] I. Reda and A. Andreas, Solar position algorithm for solar radiation
    applications. Solar Energy, vol. 76, no. 5, pp. 577-589, 2004.

    [2] I. Reda and A. Andreas, Corrigendum to Solar position algorithm for
    solar radiation applications. Solar Energy, vol. 81, no. 6, p. 838, 2007.

    [3] USNO delta T:
    http://www.usno.navy.mil/USNO/earth-orientation/eo-products/long-term

the result will change from

[1] I. Reda and A. Andreas, Solar position algorithm for solar radiation applications. Solar Energy, vol. 76, no. 5, pp. 577-589, 2004. [2] I. Reda and A. Andreas, Corrigendum to Solar position algorithm for solar radiation applications. Solar Energy, vol. 81, no. 6, p. 838, 2007. [3] USNO delta T: http://www.usno.navy.mil/USNO/earth-orientation/eo-products/long-term

to:

[1] I. Reda and A. Andreas, Solar position algorithm for solar radiation applications. Solar Energy, vol. 76, no. 5, pp. 577-589, 2004.

[2] I. Reda and A. Andreas, Corrigendum to Solar position algorithm for solar radiation applications. Solar Energy, vol. 81, no. 6, p. 838, 2007.

[3] USNO delta T: http://www.usno.navy.mil/USNO/earth-orientation/eo-products/long-term

I found some long lines (>79) at 156 and 285.

[alorenzo175]

Ok, should be fixed now. I think the remaining pep8 errors should be left alone for readability.

[uvchik]

I totally agree. Good work. It's great that the spa algorithm is now integrated in the python code. @wholmgren and @Calama-Consulting I would merge that and add it to 0.1.

[wholmgren]

Agreed on all of the above.
On Mon, Apr 20, 2015 at 11:12 AM ukrien notifications@github.com wrote:

I totally agree. Good work. It's great that the spa algorithm is now
integrated in the python code. @wholmgren https://github.com/wholmgren
and @Calama-Consulting https://github.com/Calama-Consulting I would
merge that and add it to 0.1.

—
Reply to this email directly or view it on GitHub
#50 (comment).