Skip to content

pvsystem clean up #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 20, 2015
Merged

pvsystem clean up #51

merged 13 commits into from
Apr 20, 2015

Conversation

wholmgren
Copy link
Member

The most important parts of this PR are

Less important changes:

  • I added the "effective irradiance" Ee to the pvsystem.sapm output DataFrame. Not sure if this name follows the rules or not. It's a parameter that's very specific to the Sandia model, so that makes me think that it's better to leave as Ee.
  • pvsystem.sapm can now take a dict for a module specification.
  • By line, the majority of this PR is PEP8 improvements (except the tutorial of course), especially focused on wrapping long lines. Many PEP8 issues still exist and are beyond the scope of this PR.
  • Added a note about a difference with the Matlab function. The difference has existed since the original python port.

@bmu
Copy link
Contributor

bmu commented Apr 19, 2015

I see one thing: According to the wiki systemdef should return surface_azimuth and surface_tilt instead of surfaz and surftilt.

@wholmgren
Copy link
Member Author

Thanks. Fixed that and made some other minor changes too.

@wholmgren wholmgren mentioned this pull request Apr 20, 2015
robwandrews added a commit that referenced this pull request Apr 20, 2015
@robwandrews robwandrews merged commit 8c267c8 into pvlib:master Apr 20, 2015
@robwandrews
Copy link
Contributor

This looks good! Thanks for the cleanup

@wholmgren wholmgren deleted the pvsystem-fixes branch October 28, 2015 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants