Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add airspeed velocity config and performance tests #530

Closed
wants to merge 2 commits into from

Conversation

wholmgren
Copy link
Member

@wholmgren wholmgren commented Aug 13, 2018

This pull request adds configuration and test files for the airspeed velocity performance benchmarking tool.

This is new to me, but I'm putting it up here for feedback. I developed this while benchmarking #528 and #529. It seems useful. I'm not sure what the standard should be for merging this.

@mikofski do you have any experience using asv or similar tools? Anyone else?

In the long run, it would be ideal to set up a cloud service to automatically run these tests on the same (possibly virtual) hardware each time. As of now, I only want to consider running these tests locally.

  • Closes Add a performance benchmarking tool #419
  • I am familiar with the contributing guidelines.
  • Fully tested. Added and/or modified tests to ensure correct behavior for all reasonable inputs. Tests (usually) must pass on the TravisCI and Appveyor testing services.
  • Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate docs/sphinx/source/whatsnew file for all changes.
  • Code quality and style is sufficient. Passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • New code is fully documented. Includes sphinx/numpydoc compliant docstrings and comments in the code where necessary.
  • Pull request is nearly complete and ready for detailed review.

other:

  • add a simple readme like scipy's -- rely on asv's documentation for all but the most basic commands and instructions
  • consider benchmarks/benchmarks rather than asv_bench/benchmarks (copied from xarray)

@mikofski
Copy link
Member

Airspeed velocity (asv) is used in SciPy, I had to use it to create a benchmark for the vectorized Newton PR, but that's my only experience, seems useful but not sure if there's any standard on benchmarks

@wholmgren
Copy link
Member Author

closing in favor of #1049

@wholmgren wholmgren closed this Sep 9, 2020
@wholmgren wholmgren deleted the asvbench branch September 9, 2020 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a performance benchmarking tool
2 participants