fix _delta_kt_prime_dirint end values #638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![stickler-ci[bot]](https://avatars.githubusercontent.com/in/15299?s=60&v=4){kind=small}
wholmgren
reviewed
Jan 9, 2019
8 tasks
cwhanse
pushed a commit
that referenced
this pull request
Jan 17, 2019
* Add PVSystem pvsyst_celltemp methods * fix _delta_kt_prime_dirint end values (#638) * fix _delta_kt_prime_dirint end values * syntax, test fixes: * syntax and test fixes * more test fixes * more test fixes * and more test fixes * and still more test fixes * add comments, update whatsnew * delete space * Add PVSystem pvsyst_celltemp methods * create global TEMP_MODELS for sapm and pvsyst * correct model choice in pvsyst_celltemp function * Add PVSystem pvsyst_celltemp methods * create global TEMP_MODELS for sapm and pvsyst * correct model choice in pvsyst_celltemp function * convert sapm temp models to tuples * implement _build_kwargs into pvsyst_celltemp * amend with non-default parameters and new api * Stickler-ci polish
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pvlib python pull request guidelines
Thank you for your contribution to pvlib python! You may delete all of these instructions except for the list below.
You may submit a pull request with your code at any stage of completion.
The following items must be addressed before the code can be merged. Please don't hesitate to ask for help if you're unsure of how to accomplish any of the items below:
docs/sphinx/source/api.rstfor API changes.docs/sphinx/source/whatsnewfile for all changes.Brief description of the problem and proposed solution (if not already fully described in the issue linked to above):
_delta_kt_prime_dirint does not implement Eq. 3 from Perez et al. reference in the calculation of
delta_kt_prime. Fixes that.