Updated pointers to current SAM files, updated column names, ... #80
Conversation
…d replace chars for equipment names [Issue 75]
|
I'm not too worried about the name changes since I doubt that anybody is accessing those columns directly. Is there any advantage to adding the ability to choose the data set? |
| elif name == 'sandiainverter': | ||
| url = 'https://sam.nrel.gov/sites/sam.nrel.gov/files/sam-library-sandia-inverters-2014-1-14.csv' | ||
| url = 'https://sam.nrel.gov/sites/sam.nrel.gov/files/sam-library-sandia-modules-2015-6-30.csv' | ||
| elif name == 'sandiainverter': # Still only one current inverter set, so left it as sandia, to avoid breaking old code |
There was a problem hiding this comment.
What if we do something like elif 'inverter' in name or elif name in ['sandiainverter', 'cecinverter'] to cover both the old code and the expectations of new users?
There was a problem hiding this comment.
I'll add the latter.
There was a problem hiding this comment.
Personally I don't see much value in old versions, because if you are paying that close attention to the different module or inverter parameters, you would probably do better to have a local copy that you version yourself, and can specify directly as a file (and would have to update the column names to match, but that's not hard at this point).
There was a problem hiding this comment.
Ok, good points.
The doc string needs to be updated with something about how you can use either name and there is currently no difference between the two. I will merge after that.
|
Oh, and add your change and name to the 0.2.1 whatsnew file. |
Updated pointers to current SAM files, updated column names, ...
|
Thanks @jforbess! |
and added more replace chars for equipment names [Issue 75].
The calcparams_desoto and sapm functions won't work with the previous csv files, because Sandia changed some column names between CSVs, and the change is hardcoded. It seems worth forcing the upgrade, though.