Skip to content

added link to paper. #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 21, 2015
Merged

added link to paper. #81

merged 6 commits into from
Aug 21, 2015

Conversation

dacoex
Copy link
Contributor

@dacoex dacoex commented Jul 27, 2015

added link to paper.

Maybe there can eb new page with publications

added link to paper.

Maybe there can eb new page with publications
@@ -38,7 +38,7 @@ Please see our
`PVSC 2014 paper <http://energy.sandia.gov/wp/wp-content/gallery/uploads/PV_LIB_Python_final_SAND2014-18444C.pdf>`_
and
`PVSC 2015 abstract <https://github.com/UARENForecasting/pvlib-pvsc2015/blob/master/pvlib_pvsc_42.pdf?raw=true>`_
for more information.
(and the `final paper <https://github.com/pvlib/pvsc2015>`_) for more information.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"final paper" doesn't seem like the right way to describe this. A better way might be to change "PVSC 2015 abstract" to "PVSC 2015 paper" with the correct pdf link, then replace "and the final paper" with something like "GitHub repository". I don't see any benefit to keeping the link to the abstract.

@wholmgren
Copy link
Member

@dacoex do you want to make the suggested changes or something similar? If so, please also update the change and version files.

@dacoex
Copy link
Contributor Author

dacoex commented Aug 20, 2015

OK, I made the changes.

I guess in future there may be dedicated page for the references & project links...

wholmgren added a commit that referenced this pull request Aug 21, 2015
@wholmgren wholmgren merged commit d00ef2d into pvlib:master Aug 21, 2015
@wholmgren
Copy link
Member

Thanks.

@dacoex
Copy link
Contributor Author

dacoex commented Aug 21, 2015

Easy, One cannot only talk, right?

@wholmgren wholmgren mentioned this pull request Oct 26, 2015
@@ -37,8 +37,10 @@ help updating them!
Please see our
`PVSC 2014 paper <http://energy.sandia.gov/wp/wp-content/gallery/uploads/PV_LIB_Python_final_SAND2014-18444C.pdf>`_
and
`PVSC 2015 abstract <https://github.com/UARENForecasting/pvlib-pvsc2015/blob/master/pvlib_pvsc_42.pdf?raw=true>`_
for more information.
`PVSC 2015 abstract <http://energy.sandia.gov/about/publications/download-info/pvlib-python-2015/>`_
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the correct link and I should have looked at this more closely before merging. I fixed this with commit 263c596

@wholmgren wholmgren added this to the 0.2.2 milestone Mar 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants