Skip to content

fix tmy3 leapyear in February handling, coerce_year raises exception #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jan 29, 2020
Merged

fix tmy3 leapyear in February handling, coerce_year raises exception #866

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
c5dbb29
create test for GH865
mikofski Jan 24, 2020
726137d
check it's really greensboro
mikofski Jan 24, 2020
050f034
check if the TMY Feb contains a leapyear
mikofski Jan 24, 2020
ddf19ac
add data file, update what's new
mikofski Jan 24, 2020
5d6cb8d
stickler space around operator in test
mikofski Jan 24, 2020
b1e4fd5
move warning after notes
mikofski Jan 24, 2020
5e068c3
oops, copy and paste error
mikofski Jan 24, 2020
3c09f1e
use improved snippet from Kevin Anderson
mikofski Jan 24, 2020
dc72d34
use 'h' unit string in pd.to_timedelta for min req pandas-0.18.1
mikofski Jan 24, 2020
4856552
fix first and last hour issue are 1AM and midnite
mikofski Jan 24, 2020
abf071a
remove unneeded numpy import in iotools/tmy
mikofski Jan 24, 2020
d49b53a
more explicit test for 2/29/1996 in tmy3
mikofski Jan 24, 2020
49d293c
wait to set index to avoid error in py35-min
mikofski Jan 25, 2020
77e87d2
try pandas datetime instead of index
mikofski Jan 25, 2020
6f81e58
no need to convert data_ymd to datetime
mikofski Jan 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions docs/sphinx/source/whatsnew/v0.7.2.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,17 @@
v0.7.2 (Month day, year)
-------------------------

Enhancements
~~~~~~~~~~~~
* TMY3 dataframe returned by :py:func:`~pvlib.iotools.read_tmy3` now contains
the original ``Date (MM/DD/YYYY)`` and ``Time (HH:MM)`` columns that the
indices were parsed from (:pull:`866`)

Bug fixes
~~~~~~~~~
* Fix :py:func:`~pvlib.iotools.read_tmy3` parsing when February contains
a leap year (:pull:`866`)

Documentation
~~~~~~~~~~~~~
* Add NumFOCUS affiliation to Sphinx documentation :pull:`862`
Expand Down
Loading