-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Expose temperature.faiman in PVSystem and ModelChain #897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
0365117
remove unused pvsyst_celltemp parameter docs
kandersolar 857e63c
fix up temperature.faiman docstring formatting
kandersolar 88e7645
add pvsystem.PVSystem.faiman_celltemp
kandersolar 229c3ae
add faiman model to ModelChain
kandersolar e0fbfc3
fix copy/paste error
kandersolar 532bfd6
add test
kandersolar 2dbf15a
whatsnew
kandersolar 81813a8
Merge remote-tracking branch 'upstream/master' into faiman_integration
kandersolar ae9f970
fix whatsnew
kandersolar de60912
add GH links to whatsnew entry
kandersolar b86fbbe
split up MC cell temp tests; add faiman test
kandersolar 14bcacd
add faiman to MC infer_temp_model test; change test to check inferred…
kandersolar f668a5d
add MC.faiman_temp to api.rst
kandersolar 645698c
delete duplicate pvsystem test
kandersolar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see N0CT is used in other docstrings, but I don't see a definition anywhere. Could be a follow up issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOCT = Nominal Cell Operating Temperature. Maybe spell out the acronym?
We could add a Note with the definition: NOCT is cell temperature in conditions of irradiance 800 W/m2, ambient air temperature 20C, wind speed 1m/s and cell at Voc, reference to IEC 61215-2 but I'm guessing on the part, I can check when in the office tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cwhanse I'm happy to copy/paste a Note snippet from you into this PR, but I'll point out that NOCT is also used in the docstrings of
PVSystem.pvsyst_celltemp
,temperature.pvsyst_cell
, andtemperature.faiman
. I wonder if instead of including definitions in docstrings, it might be better to have a central list of definitions somewhere in the sphinx docs? Or just rely on the PVPMC website or PVCDROM (which as a page on NOCT already)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Let’s address it separately if at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CameronTStark I re-approve this PR for merge :)