-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add hsu soiling model gallery example. #990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think examples that recreate figures from the reference paper are a good idea. It's another layer of tests, in a way. For seeing if the example script works as expected, you have two options:
|
I have no idea why "(1,2)" shows up in front of the reference. on the doc page: [https://pvlib-python--990.org.readthedocs.build/en/990/auto_examples/plot_fig3A_hsu_soiling_example.html] Any ideas? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are some quick notes. It would be cool to also recreate Figure 4, but that would need the PRISM dataset as well.
This is a recurring point of confusion :) It's because we're using footnotes for references. Those are links to the places in the text where that citation is referenced. It's referenced in two places, so it links them as a list (1,2). It's a little strange, but that output is (for now) the right way to do it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @jsstein and @kanderso-nrel
Tests addedUpdates entries todocs/sphinx/source/api.rst
for API changes.docs/sphinx/source/whatsnew
for all changes. Includes link to the GitHub Issue with:issue:`num`
or this Pull Request with:pull:`num`
. Includes contributor name and/or GitHub username (link with:ghuser:`user`
).