Skip to content

Add hsu soiling model gallery example. #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 27, 2020
Merged

Conversation

jsstein
Copy link
Contributor

@jsstein jsstein commented Jun 20, 2020

  • [x ] Closes Add hsu soiling model example #989
  • [x ] I am familiar with the contributing guidelines
  • Tests added
  • Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.

@jsstein
Copy link
Contributor Author

jsstein commented Jun 20, 2020

This is my first gallery example, I am not sure if I did it right. I followed other examples the best I could, but I was unable to figure out how to check how the figures look. Any suggestions on how to do that? Thanks!

It should look like this:
image

followed by this image from the original paper:
image

@kandersolar
Copy link
Member

I think examples that recreate figures from the reference paper are a good idea. It's another layer of tests, in a way.

For seeing if the example script works as expected, you have two options:

@jsstein
Copy link
Contributor Author

jsstein commented Jun 20, 2020

I have no idea why "(1,2)" shows up in front of the reference. on the doc page: [https://pvlib-python--990.org.readthedocs.build/en/990/auto_examples/plot_fig3A_hsu_soiling_example.html] Any ideas?

Copy link
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some quick notes. It would be cool to also recreate Figure 4, but that would need the PRISM dataset as well.

@kandersolar
Copy link
Member

I have no idea why "(1,2)" shows up in front of the reference. on the doc page: [https://pvlib-python--990.org.readthedocs.build/en/990/auto_examples/plot_fig3A_hsu_soiling_example.html] Any ideas?

This is a recurring point of confusion :) It's because we're using footnotes for references. Those are links to the places in the text where that citation is referenced. It's referenced in two places, so it links them as a list (1,2). It's a little strange, but that output is (for now) the right way to do it.

@cwhanse cwhanse added this to the 0.8.0 milestone Jun 22, 2020
Copy link
Member

@cwhanse cwhanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @jsstein and @kanderso-nrel

@wholmgren wholmgren merged commit 8ca32c9 into pvlib:master Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add hsu soiling model example
4 participants