Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share and re-use of esp8266web code #2

Open
amirgon opened this issue Jun 21, 2015 · 1 comment
Open

Share and re-use of esp8266web code #2

amirgon opened this issue Jun 21, 2015 · 1 comment

Comments

@amirgon
Copy link

amirgon commented Jun 21, 2015

Hi pvvx,
First I wanted to say you did an excellent work of reverse engineering the closed ESP SDK. Well done!
I would like to re-use parts of your code on my projects, for example the lwip, adc etc.
A good way would be using git submodules.

However, currently your repository is not friendly for sharing with other projects as submodules:

  • Folders are not self contained. For exapmle, lwip is in one directory but it requires eagle_lwip_if.c from app/main to work correctly. Ideally I would like a single directory to contain all networking code so I could use it in my project as a submodule.
  • Comments are written in russian :(

Another option for me is to just to copy your files to my project. But if I do that I will not be able to contribute back if I make any changes/additions, and it will become harder for me to get in sync when you make changes.

Ideally, I think the best thing is to have an "open-sdk" which is a project by itself, and "esp8266web" is one project that uses it. Myself I'm not interested in the web server code, for example.

This is just a suggestion. Even if you do nothing with it, I still think you did a great job so far!

Amir

@katyo
Copy link

katyo commented Jan 4, 2016

Hi amirgon,

Almost all ESP SDK implemented so, as use it as submodules is a non-trivial thing. But it is very convenient in practice. The common problem is tricky and non-adaptable build rules, which can't be simple included into Makefile your apps.

In order to eliminate voodoo magic, which goes yet from Espressif's developers, I completely rewrote build rules in my own fork of SDK at katyo:ESP_SDK_Library.
So, bad things, like nested invocations of make, are fully removed.
Instead of that I implemented strict dependency-driven building rules.

You can see the usage example kayo:esp-lilium (be aware, this project isn't yet completed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants