Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature][Site] App Capabilities #4390

Merged
merged 26 commits into from
Oct 9, 2023
Merged

[Feature][Site] App Capabilities #4390

merged 26 commits into from
Oct 9, 2023

Conversation

Jaylyn-Barbee
Copy link
Contributor

fixes #4034

PR Type

Feature

PR Checklist

  • Test: run npm run test and ensure that all tests pass
  • Target main branch (or an appropriate release branch if appropriate for a bug fix)
  • Ensure that your contribution follows standard accessibility guidelines. Use tools like https://webhint.io/ to validate your changes.

Additional Information

@Jaylyn-Barbee
started work on caps card, updated indicators, filtering works from i…
ee5b59c 
…ndicators.
@Jaylyn-Barbee
app caps card basically done
46288b4
@Jaylyn-Barbee
filtering works as expected, security pop up appears, todo: sw card, …
5cb80b6 
…share card, mani tooltip on filters
@Jaylyn-Barbee
updated icons and add security todos
c256ad0
@Jaylyn-Barbee
notification tooltip done, sw icons set except the has service worker…
8be8592 
… icon, need to add tooltips for sw info, found bug with no manifest
@Jaylyn-Barbee
small udpate
6b0e09b
@Jaylyn-Barbee
special strings added + fall back for no manifest
f30b991
@Jaylyn-Barbee
share card updated
0360861
@Jaylyn-Barbee
fixed tooltip issue and added tooltips to sw icons. also fixed the sp…
b663a1a 
…ecial strings in the todo list
@Jaylyn-Barbee
finished doing work from design review, one more review then analytic…
55922bd 
…s added and done.
@Jaylyn-Barbee
Ready for merge
96f2b5f
@microsoft-github-policy-service
Copy link
Contributor

Thanks Jaylyn-Barbee for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@Jaylyn-Barbee Jaylyn-Barbee changed the title Jay/app capps 0923 [Feature][Site] App Capabilities Sep 25, 2023
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-glacier-097fe8710-4390.centralus.2.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-glacier-097fe8710-4390.centralus.2.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-glacier-097fe8710-4390.centralus.2.azurestaticapps.net

@Jaylyn-Barbee Jaylyn-Barbee mentioned this pull request Sep 27, 2023
Closed
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-glacier-097fe8710-4390.centralus.2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-glacier-097fe8710-4390.centralus.2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-glacier-097fe8710-4390.centralus.2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-glacier-097fe8710-4390.centralus.2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-glacier-097fe8710-4390.centralus.2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-glacier-097fe8710-4390.centralus.2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-glacier-097fe8710-4390.centralus.2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-glacier-097fe8710-4390.centralus.2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-glacier-097fe8710-4390.centralus.2.azurestaticapps.net

zateutsch
zateutsch approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@zateutsch zateutsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Jaylyn-Barbee Jaylyn-Barbee added this pull request to the merge queue Oct 9, 2023
Merged via the queue into staging with commit 7c15daf Oct 9, 2023
5 of 6 checks passed
@Jaylyn-Barbee Jaylyn-Barbee deleted the jay/app-capps-0923 branch October 9, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zateutsch zateutsch zateutsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jaylyn-Barbee @zateutsch