Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: playwright tests #4829

Merged
merged 2 commits into from
Oct 9, 2024
Merged

fix: playwright tests #4829

merged 2 commits into from
Oct 9, 2024

Conversation

maiconcarraro
Copy link
Contributor

@maiconcarraro maiconcarraro commented Oct 8, 2024

PR Type

  • Build or CI related changes

Describe the current behavior?

The existing npm run tests is using a hardcoded URL mapped to https://preview.pwabuilder.com/reportcard?site=https://webboard.app which isn't working (outdated env variable) and also doesn't help validate localhost.

Describe the new behavior?

Keep existing setup for CI, and allow localhost sanity check run for devs.

image

PR Checklist

  • Test: run npm run test and ensure that all tests pass
  • Target main branch (or an appropriate release branch if appropriate for a bug fix)
  • Ensure that your contribution follows standard accessibility guidelines. Use tools like https://webhint.io/ to validate your changes.

Additional Information

Copy link
Contributor

Thanks maiconcarraro for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@jgw96 jgw96 enabled auto-merge October 9, 2024 16:54
@jgw96 jgw96 added this pull request to the merge queue Oct 9, 2024
Merged via the queue into pwa-builder:main with commit bf1ac8a Oct 9, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants