Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Support modifying history text in CLI #38

Open
daschewie opened this issue May 19, 2022 · 1 comment
Open

[Enhancement] Support modifying history text in CLI #38

daschewie opened this issue May 19, 2022 · 1 comment
Assignees
@pweingar
Labels
bug Something isn't working

Comments

@daschewie
Copy link
Contributor

Background

The CLI recently added support for line editing and history. For new text, it allows you to backspace or use arrows to edit text. However when you use the up arrow to pull up a history entry, it allows you to append to the text but not edit it.

Proposal

Please add line edit support for history entries. Another recommendation would be to consider adapting Linenoise. It is VT100 clone of libreadline that has no dependencies and is less than 1k lines.
@pweingar pweingar added the bug Something isn't working label May 20, 2022
@pweingar pweingar self-assigned this May 20, 2022
@pweingar
Copy link
Owner

This is actually a bug... it was supposed to do it. Fortunately, it seems like I made a very simple mistake.

pweingar added a commit that referenced this issue May 20, 2022
@pweingar
Issue #38
dff1567 
Fixed a bug that was preventing commands brought back from history from being editable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pweingar pweingar

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@daschewie @pweingar