Connector uses unsupported API (#47) #50
Conversation
- Updated Licensing information to show about and added third party licenses as much as they are available - Updated plugin license information for java-gitlab-api - Replaced external libraries as needed by java gitlab api 4.0.x - Added jackson-core 2.5.3 - Added jackson-databind 2.5.3 - Added jackson-annotations 2.5.3 - Added commons-io 2.4 - Included local Snapshot build of java-gitlab-api 4.0.1 - Added snapshots to gitignore file - Fixed compile issues due to changes in java-gitlab-api
| <p>July, 2016</p> | ||
| <h3>License</h3> | ||
|
|
||
| <p> Unless otherwise indicated below, all content of this plugin "Content" is provided to you under the terms |
There was a problem hiding this comment.
@pweingardt usually if you look into the about.html of eclipse plugins. The author is emntiones as well in a way such as "The content of this plugin is made available by pweingart". Was not sure if you would like it or not. Please check if you like it or not.
|
IMO the license bit probably should have been a separate PR. You've mixed a couple issues in one PR so it became pretty big (24 files is not a small amount). It's not clear if the license files were copied from the repository license or elsewhere at a glance. |
|
@PhilMFischer How would it be possible to test it locally ? I mean deploy it in a Photon Eclipse installation for instance. Sadly, I don't know much about Eclipse plugins... |
|
I will look into this pull request on the weekend. |
|
Would it help to integrate this PR if we split it into two separate ones; one for API v4 and one for the licensing? Or get you a beer or a coffee? ;) |
Fixed compile issues due to changes in java-gitlab-api
Prepared for Including local Snapshot build of java-gitlab-api 4.0.1 with fixes of GitlabAPI.getNotes(...) call creating non api v4 compliant URL (#283) timols/java-gitlab-api#284
Added snapshots to gitignore file
Replaced external libraries as needed by java gitlab api 4.0.x
Added jackson-core 2.5.3
Added jackson-databind 2.5.3
Added jackson-annotations 2.5.3
Added commons-io 2.4
Updated Licensing information to show about and added third party licenses as much as they are available. Now following eclipse style handling the licenses in plugins.
Updated plugin license information for java-gitlab-api