Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional scan param for url report API #5

Merged
merged 1 commit into from
Mar 27, 2018

Conversation

mkunkel
Copy link
Contributor

@mkunkel mkunkel commented Mar 15, 2018

The url report API accepts an optional parameter of scan, which, if set to 1 will queue a scan of the submitted URL.
This adds the possibility of queuing a scan for urls

@mkunkel
Copy link
Contributor Author

mkunkel commented Mar 15, 2018

@pwelch requesting review

@mkunkel
Copy link
Contributor Author

mkunkel commented Mar 15, 2018

Check failed due to rubocop warnings unrelated to this PR

@pwelch pwelch added this to the v0.3.0 milestone Mar 15, 2018
@pwelch pwelch added the blocked label Mar 15, 2018
@pwelch
Copy link
Owner

pwelch commented Mar 15, 2018

@mkunkel Thanks for the PR!

Looks like Rubocop might be out of date. I've created an issue to update the gem overall and fix the Rubocop violations. Once that's in master, I'll rerun the build and clean up any issues. I'll let you know when I publish this change to RubyGems.

@pwelch
Copy link
Owner

pwelch commented Mar 25, 2018

@mkunkel I've updated the repo. Can you rebase and push up your branch so Travis will pass?

The url report API accepts an optional parameter of `scan`, which, if
set to `1` will queue a scan of the submitted URL.
This adds the possibility of queuing a scan for urls
@mkunkel
Copy link
Contributor Author

mkunkel commented Mar 26, 2018

@pwelch PR updated

@pwelch pwelch merged commit d5b525d into pwelch:master Mar 27, 2018
@pwelch
Copy link
Owner

pwelch commented Mar 27, 2018

@mkunkel merged! I'll let you know when the gem is published.

@mkunkel mkunkel deleted the scan-param branch March 27, 2018 14:47
@pwelch
Copy link
Owner

pwelch commented Mar 31, 2018

@mkunkel Gem published: https://rubygems.org/gems/virustotal_api

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants