Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing RCTBridge import to React namespace per RN 0.40 update #31

Merged
merged 2 commits into from
Sep 27, 2017

Conversation

isaacnass
Copy link
Contributor

In React Native 0.40 everyone is getting duplicate class errors, this fixes those 👍

@johanblomgren
Copy link

Awaiting the merge of this PR. 0.40 should be fairly established by now.

@stephanedemotte
Copy link

@isaacnass push ?

@isaacnass
Copy link
Contributor Author

@stephanedemotte Push what? I am lé open source n00b I have no idea what I'm doing 😛

@johanblomgren
Copy link

It's @pwmckenna who needs to accept or dismiss this PR.

@stephanedemotte
Copy link

@isaacnass hihi, same here 💃
So @pwmckenna acceeeeept and bump it up ! ;)

@MaxMillington
Copy link

+1. Please merge this

@peterept
Copy link

Yes, please merge. Took me ages to figure this out also, and only then saw this PR. I will add an issue

@armenr
Copy link

armenr commented Apr 3, 2017

+1. Had to figure this out manually over the course of a full day. Would be a major help :)

@pwmckenna
Copy link
Owner

pwmckenna commented Aug 1, 2017

@isaacnass just added you as a contributor to this project and will be giving you npm access as well. Sorry for the delay, and thanks for the contribution. 👍

Mind sending me your npm username?

@wewark
Copy link

wewark commented Aug 16, 2017

Why hasn't this been merged yet? I had to copy the whole project out of node_modules to make these exact changes.

@pwmckenna
Copy link
Owner

@wewark I haven't merged it because I don't have time to verify that this is a good patch. If you're interested I'd be happy to give you access to both this repo and npm so you can publish updates.

@pwmckenna pwmckenna merged commit fdaec01 into pwmckenna:master Sep 27, 2017
@pwmckenna
Copy link
Owner

@isaacnass thanks for the pr. I didn't have time to verify this, but there was enough demand that I merged and published as 0.0.7. If there are any more pressing issues, I'm happy to hand out write access so I'm not a bottleneck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants