Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

​​​Discarding entity body for GET requests​​​ logging is surfacing through all my XHR requests #49

Open
loganpowell opened this issue Aug 31, 2022 · 0 comments
Open

​​​Discarding entity body for GET requests​​​ logging is surfacing through all my XHR requests #49

loganpowell opened this issue Aug 31, 2022 · 0 comments

Comments

@loganpowell
Copy link

Hi @pwnall

First, thank you for patching xhr in Node! I'm using this as a cross-platform shim, but when I'm in node, I'm getting a bunch of Discarding entity body for GET requests​​​ warnings that are injected throughout my logs. The culprit line is here. Would you mind silencing this by default and allowing users to opt-in to see it? Here are a couple issues I found referencing the same complaint:

Just goes to show your library is very popular!
loganpowell added a commit to loganpowell/node-xhr2 that referenced this issue Sep 1, 2022
@loganpowell
Resolves 49
a1d9fa3 
WRT pwnall#49 removes logging for empty-bodied GET requests
@loganpowell loganpowell mentioned this issue Sep 1, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@loganpowell