Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include type defintion #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PatrickJS
Copy link

I need this for Universal Angular 2 which uses typescript

update: could you also release a patch update

@pwnall
Copy link
Owner

pwnall commented Jan 21, 2016

I'm not definitely saying no to this patch, but is there another way of accomplishing its goal? Does TypeScript really expect to creep into every package in your system?

@PatrickJS
Copy link
Author

yeah, there is a typings manager but the most seamless way is having the repo itself provide the types so there won't be any version conflicts. soon we won't need "typescript": { "definition": "xhr2.d.ts" }, when tsd (legacy types manager)

@pwnall
Copy link
Owner

pwnall commented Jan 21, 2016

This repo's goal is to implement the W3C XHR2 spec. Given the state of the spec, it is unlikely that the public API provided by the repo will ever change. Based on the xhr2.d.ts contents I've seen in the PR, it seems like there would never be an opportunity for a versioning conflict. Am I understanding this the wrong way?

@pwnall
Copy link
Owner

pwnall commented Jan 21, 2016

Just to be clear about my intentions: I don't want to make your life hard on purpose. I'm pushing back because I'm not too thrilled about potentially having to include dedicated code for every language that compiles to JS out there.

If the alternative has a terrible price (e.g., if every Angular user has to create that .d.ts file) then I will look into what it'd take to get some test coverage for this definition and merge it.

@PatrickJS
Copy link
Author

every angular (ember is also going to use typescript) users would have to do a typings install xhr or create their own defintion. If someone installs their XMLHttpRequest then it will merge with this definition which includes the non-standard nodejsSet that I requested before. I can also volenteer to keep the definition file updated

@PatrickJS PatrickJS force-pushed the type-def branch 2 times, most recently from 87803a9 to 6b90a5d Compare January 22, 2016 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants