Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace: Handle service starts gracefully #444

Closed
wants to merge 1 commit into from

Conversation

ConnorNelson
Copy link
Member

No description provided.

@ConnorNelson
Copy link
Member Author

I think it would make sense to do something like use javascript to poll every second to see if the service is ready (e.g. container exists, container is running, service is running). Once that has been confirmed, let the iframe show up. In the meantime have a "loading" animation. Do this for 20s and then give up and tell the user no challenge is running.

@spencerpogo
Copy link
Contributor

does that mean that if you truly don't have a challenge running, you have to wait 20s to find out?

@ConnorNelson
Copy link
Member Author

Yeah it definitely would.

What we could do is be more informative about the process as we are with SSH. Maybe instead we check if the container exists in any state at all (e.g. even just "Created"); if not, immediately report no challenge started, otherwise poll for service-readiness for ~20 seconds.

@ConnorNelson
Copy link
Member Author

#478 has a better discussion of what this should look like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants