Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated GitHub actions #2305

Merged
merged 4 commits into from
Feb 18, 2024
Merged

Conversation

MattHag
Copy link
Collaborator

@MattHag MattHag commented Feb 17, 2024

Upgrade actions leveraging Node.js 20

#2256, #2284

Refactor setup steps to unify commands between Linux and macOS.
Move bash commands into Makefile for consistency and enable local
execution of GitHub CI commands corresponding Makefile targets.

Install on Ubuntu:
make install_ubuntu

Install on Ubuntu for development:
make install_ubuntu PIP_ARGS=."[test]"

Fixes pwr-Solaar#2303
Replaces deprecated Node.js 16 actions.

Related pwr-Solaar#2256, pwr-Solaar#2284
@pfps
Copy link
Collaborator

pfps commented Feb 18, 2024

OK, now that 1.1.11 is out it is time to merge several PRs. Is there any particular order in which they need to be merged?

@MattHag
Copy link
Collaborator Author

MattHag commented Feb 18, 2024

This one on top of the extended makefile.

@pfps pfps merged commit ad11049 into pwr-Solaar:master Feb 18, 2024
5 checks passed
@pfps
Copy link
Collaborator

pfps commented Feb 18, 2024

Thanks.

@pfps
Copy link
Collaborator

pfps commented Feb 18, 2024

@MattHag Given that you are putting in work, it seems reasonable to make you a member of the Solaar developers in GitHub. If you are interested, let me know.

@MattHag MattHag deleted the upgrade_github_actions branch April 3, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants