Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Creation of devices #2493

Merged
merged 2 commits into from
May 27, 2024
Merged

Conversation

MattHag
Copy link
Collaborator

@MattHag MattHag commented May 19, 2024

  • Explicitly pass low level dependency to simplify testing with fakes.

Related #1097

@MattHag MattHag marked this pull request as draft May 20, 2024 07:18
@MattHag MattHag force-pushed the testable_interface branch from 7fbb85f to 6f4280c Compare May 20, 2024 07:39
@MattHag MattHag marked this pull request as ready for review May 20, 2024 07:40
@MattHag MattHag force-pushed the testable_interface branch 2 times, most recently from eff9dd7 to 2408c0b Compare May 23, 2024 07:31
@pfps
Copy link
Collaborator

pfps commented May 23, 2024

Needs updating

@MattHag MattHag marked this pull request as draft May 23, 2024 21:47
@MattHag MattHag force-pushed the testable_interface branch 3 times, most recently from 858456b to 4bb3cb4 Compare May 24, 2024 07:11
@MattHag MattHag marked this pull request as ready for review May 24, 2024 07:13
@MattHag MattHag force-pushed the testable_interface branch from 4bb3cb4 to 52f08dc Compare May 26, 2024 13:55
Copy link
Collaborator

@pfps pfps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@pfps pfps merged commit c29231b into pwr-Solaar:master May 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants