Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated results verification #25

Merged
merged 1 commit into from
Mar 15, 2022
Merged

updated results verification #25

merged 1 commit into from
Mar 15, 2022

Conversation

pxp928
Copy link
Owner

@pxp928 pxp928 commented Mar 15, 2022

Signed-off-by: pxp928 parth.psu@gmail.com

Updated Chains to use upstream pipeline IsTaskRunResultVerified for verification of signed TaskRun results.

Signed-off-by: pxp928 <parth.psu@gmail.com>
} else {
if len(tr.Status.TaskRunResults) > 0 {
if len(tr.Status.TaskRunResults) > 0 {
if !tr.IsTaskRunResultVerified() {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: combine lines of if statement

@pxp928 pxp928 merged commit b22127f into spire-main Mar 15, 2022
pxp928 added a commit that referenced this pull request Mar 29, 2022
Signed-off-by: pxp928 <parth.psu@gmail.com>
pxp928 added a commit that referenced this pull request Apr 1, 2022
Signed-off-by: pxp928 <parth.psu@gmail.com>
pxp928 added a commit that referenced this pull request Apr 1, 2022
Signed-off-by: pxp928 <parth.psu@gmail.com>
pxp928 added a commit that referenced this pull request May 5, 2022
Signed-off-by: pxp928 <parth.psu@gmail.com>
pxp928 added a commit that referenced this pull request May 5, 2022
Signed-off-by: pxp928 <parth.psu@gmail.com>
pxp928 added a commit that referenced this pull request Jun 16, 2022
Signed-off-by: pxp928 <parth.psu@gmail.com>
pxp928 added a commit that referenced this pull request Jul 29, 2022
Signed-off-by: pxp928 <parth.psu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants