Spire injection client #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brandon Lum <lumjjb@gmail.com>
pxp928
reviewed
Jul 15, 2022
| type controllerKey struct{} | ||
|
|
||
| // GetControllerAPIClient extracts the ControllerAPIClient from the context. | ||
| func GetControllerAPIClient(ctx context.Context) ControllerAPIClient { |
There was a problem hiding this comment.
Doing some testing here. Seems like I am running into the untyped == nil. Do I need to setup the context in some way for this to work?
There was a problem hiding this comment.
hmm interesting, yea maybe it requires setting up the context with the injection library.
| ) | ||
|
|
||
| func init() { | ||
| injection.Fake.RegisterClient(withFakeControllerClient) | ||
| injection.Fake.RegisterClient(withFakeEntrypointerClient) |
There was a problem hiding this comment.
This works with the mocked spire tests. But why don't you need the GetEntrypointerAPIClient here?
pxp928
pushed a commit
that referenced
this pull request
Jul 27, 2022
Signed-off-by: Brandon Lum <lumjjb@gmail.com>
pxp928
pushed a commit
that referenced
this pull request
Jul 28, 2022
Signed-off-by: Brandon Lum <lumjjb@gmail.com>
pxp928
pushed a commit
that referenced
this pull request
Aug 4, 2022
Signed-off-by: Brandon Lum <lumjjb@gmail.com>
pxp928
pushed a commit
that referenced
this pull request
Aug 9, 2022
Signed-off-by: Brandon Lum <lumjjb@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.