-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hidden files (i.e. .coverage
) are now excluded by upload_artifact
v3 & v4 by default
#470
Comments
damn. Do you want to do the contribution to the README ? |
@ewjoachim sure, why not! |
Fixed by #471 (I also added a small comment regarding the security aspect you mentioned) |
jjaakola-aiven
added a commit
to Aiven-Open/karapace
that referenced
this issue
Sep 18, 2024
nosahama
pushed a commit
to Aiven-Open/karapace
that referenced
this issue
Sep 18, 2024
jjaakola-aiven
added a commit
to Aiven-Open/karapace
that referenced
this issue
Sep 18, 2024
jjaakola-aiven
added a commit
to Aiven-Open/karapace
that referenced
this issue
Sep 18, 2024
jjaakola-aiven
added a commit
to Aiven-Open/karapace
that referenced
this issue
Sep 18, 2024
jjaakola-aiven
added a commit
to Aiven-Open/karapace
that referenced
this issue
Sep 18, 2024
jjaakola-aiven
added a commit
to Aiven-Open/karapace
that referenced
this issue
Sep 18, 2024
jjaakola-aiven
added a commit
to Aiven-Open/karapace
that referenced
this issue
Sep 18, 2024
jjaakola-aiven
added a commit
to Aiven-Open/karapace
that referenced
this issue
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From github changelog notice
The consequence of this:
When using the provided example workflows, the
upload_artifact
steps will ignore any.coverage*
file.One approach to address this could simply be to add the option
include-hidden-files
as option for theupload_artifact
action in the provided examples.Another approach might be to not create hidden files in the first place (e.g. setting
COVERAGE_FILE: "_coverage"
, or similar).The latter approach would probably be better in line with the security policy that lead to the decision to ignore hidden files in artifacts in the first place.
The text was updated successfully, but these errors were encountered: