Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hidden files (i.e. .coverage) are now excluded by upload_artifact v3 & v4 by default #470

Closed
j-i-l opened this issue Sep 2, 2024 · 3 comments

Comments

@j-i-l
Copy link
Contributor

j-i-l commented Sep 2, 2024

From September 2nd, 2024, we will no longer include hidden files and folders as part of the default upload of the v3 and v4 upload-artifact actions. This reduces the risk that credentials are accidentally uploaded into artifacts. Customers who need to continue to upload these files can use a new option, ‘include-hidden-files’, to continue to do so.

From github changelog notice

The consequence of this:

When using the provided example workflows, the upload_artifact steps will ignore any .coverage* file.


One approach to address this could simply be to add the option include-hidden-files as option for the upload_artifact action in the provided examples.
Another approach might be to not create hidden files in the first place (e.g. setting COVERAGE_FILE: "_coverage", or similar).

The latter approach would probably be better in line with the security policy that lead to the decision to ignore hidden files in artifacts in the first place.

@ewjoachim
Copy link
Member

damn.

Do you want to do the contribution to the README ?

@j-i-l
Copy link
Contributor Author

j-i-l commented Sep 2, 2024

@ewjoachim sure, why not!

@ewjoachim
Copy link
Member

Fixed by #471 (I also added a small comment regarding the security aspect you mentioned)

@ewjoachim ewjoachim pinned this issue Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants