Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit-ci #375

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

juanitorduz
Copy link
Contributor

This PR suggests using pre-commit-ci (https://pre-commit.ci/) so that the versions of the pre-commit hooks get automatically updated weekly. If any package needs an update, a pre-commit PR will be opened every week. This is much better than doing it by hand and ensuring the lint and code style do not break without warning. Here is an example of such PR from one of my projects: pymc-labs/pymc-marketing#642

Once (and if) this PR is merged, @s3alfisc you need to sign up with GitHub and approve the integration of the pre-commit app here: https://pre-commit.ci/

Important: pre-commit.ci will always be free for open source repositories. (from the documentation)

@juanitorduz
Copy link
Contributor Author

The test fails (3.11) from https://github.com/s3alfisc/pyfixest/actions/runs/8837489162/job/24266463332?pr=375 has nothing to do with this change. Maybe you can try to re-run the job?

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.90%. Comparing base (35b47e9) to head (e2f9e3a).
Report is 43 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #375      +/-   ##
==========================================
- Coverage   85.79%   81.90%   -3.89%     
==========================================
  Files          38       53      +15     
  Lines        3421     4178     +757     
==========================================
+ Hits         2935     3422     +487     
- Misses        486      756     +270     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@s3alfisc
Copy link
Member

Thank you, this will be very useful =)

@s3alfisc s3alfisc merged commit f3e769f into py-econometrics:master Apr 25, 2024
8 of 9 checks passed
@s3alfisc
Copy link
Member

& permission granted 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants