Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pyright from 1.1.326 to 1.1.360 #264

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 27, 2024

Bumps pyright from 1.1.326 to 1.1.360.

Commits
  • 642e0e9 Pyright NPM Package update to 1.1.360 (#266)
  • fbc68e1 [pyright updated to 1.1.359] Update Version (#264)
  • 7191b6c [pyright updated to 1.1.358] Update Version (#260)
  • 8f677a9 Pyright NPM Package update to 1.1.357 (#259)
  • 3c598b3 Pyright NPM Package update to 1.1.356 (#257)
  • 27a9fea Pyright NPM Package update to 1.1.355 (#256)
  • 3b04c54 [pyright updated to 1.1.354] Update Version (#255)
  • ba2747b Pyright NPM Package update to 1.1.353 (#253)
  • 1b36e5d Pyright NPM Package update to 1.1.352
  • 47b23ec Drop support for node.js v12
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added a: dependencies Related to package dependencies and management p: 3 - low This can wait t: enhancement Improvement to an existing feature labels Apr 27, 2024
@py-mine-ci-bot py-mine-ci-bot bot enabled auto-merge (squash) April 27, 2024 20:42
Bumps [pyright](https://github.com/RobertCraigie/pyright-python) from 1.1.326 to 1.1.360.
- [Release notes](https://github.com/RobertCraigie/pyright-python/releases)
- [Commits](RobertCraigie/pyright-python@v1.1.326...v1.1.360)

---
updated-dependencies:
- dependency-name: pyright
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/pip/pyright-1.1.360 branch from 9708b1b to 421659f Compare April 27, 2024 20:51
@ItsDrike
Copy link
Member

ItsDrike commented Apr 29, 2024

Hm, the reason for most of these failures seems to be that pyright no longer accepts returning enum variants from classmethods annotated to return Self. This looks like a bug/regression, I have reported it to pyright, this PR is blocked until the issue gets addressed: microsoft/pyright#7798. These will need to be changed to the class names, since Self doesn't make sense for enums, which don't support inheritance anyways.

Another issue that appears here has to do with the following: microsoft/pyright#5933 This is a valid problem, and we will need to address it to be able to upgrade pyright.

This mainly addresses two types of issues:

- <microsoft/pyright#7798>: Using `Self` as a
  return type from `Enum` classmethods isn't supported, the class (name)
  should be used instead.
- <microsoft/pyright#5933>: Mutable field
  invariance - subclasses shouldn't be able to contravariantly narrow an
  inherited variable.
@ItsDrike ItsDrike disabled auto-merge April 29, 2024 19:48
@ItsDrike ItsDrike merged commit 53aac51 into main Apr 29, 2024
13 checks passed
@ItsDrike ItsDrike deleted the dependabot/pip/pyright-1.1.360 branch April 29, 2024 19:49
@ItsDrike ItsDrike mentioned this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: dependencies Related to package dependencies and management p: 3 - low This can wait t: enhancement Improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant