Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise better error if server doesn't return a full answer #512

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Raise better error if server doesn't return a full answer #512

merged 1 commit into from
Apr 17, 2023

Conversation

PerchunPak
Copy link
Member

Closes #511.

@PerchunPak PerchunPak added type: enhancement Improvement to an existing feature status: needs review Author is waiting for someone to review and approve area: protocol Related to underlying networking protocol labels Apr 15, 2023
@PerchunPak PerchunPak mentioned this pull request Apr 15, 2023
Closed
ItsDrike
ItsDrike reviewed Apr 15, 2023
View reviewed changes
mcstatus/protocol/connection.py Outdated Show resolved Hide resolved
mcstatus/protocol/connection.py Outdated Show resolved Hide resolved
@ItsDrike ItsDrike changed the title Raise better error if server returns not a full answer Raise better error if server doesn't return a full answer Apr 15, 2023
@PerchunPak PerchunPak force-pushed the raise-better-error-if-server-returns-not-a-full-answer branch 2 times, most recently from 9c4af29 to 77dfd35 Compare April 15, 2023 08:44
@PerchunPak PerchunPak force-pushed the raise-better-error-if-server-returns-not-a-full-answer branch from 77dfd35 to 9a6f4ad Compare April 16, 2023 19:03
@ItsDrike ItsDrike merged commit 93461e2 into master Apr 17, 2023
@ItsDrike ItsDrike deleted the raise-better-error-if-server-returns-not-a-full-answer branch April 17, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItsDrike ItsDrike ItsDrike approved these changes

@kevinkjt2000 kevinkjt2000 kevinkjt2000 approved these changes

Assignees
No one assigned
Labels
area: protocol Related to underlying networking protocol status: needs review Author is waiting for someone to review and approve type: enhancement Improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IndexError: bytearray index out of range
3 participants
@PerchunPak @kevinkjt2000 @ItsDrike