-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Forge Data Decoder #578
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a quick look, will continue when you will fix the CI. But I am happy that this feature finally will be added to mcstatus!
Co-authored-by: Perchun Pak <github@perchun.it>
Co-authored-by: Perchun Pak <github@perchun.it>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more fast review, some later will dig into the protocol and the algorithm.
Co-authored-by: Perchun Pak <github@perchun.it>
I thought this was done a long time ago, kind of forgot it was still open. |
|
So could you answer open conversations? As far as I can remember, it's almost ready for merge, except for those two things. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't expect to find this amount of things to improve, but it's almost ready.
Co-authored-by: Perchun Pak <github@perchun.it>
Co-authored-by: Perchun Pak <github@perchun.it>
Co-authored-by: Perchun Pak <github@perchun.it>
I think it would be easier if I will just commit those changes, that I proposed in review. Of course if you don't mind |
Sure thing, I would like to see these changes merged in one way or another so I don't need to maintain my own module to do it because of lack of support. |
I honestly forgot what I wanted to do here and how this code works. Fixed only what I wrote about in last review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's been a while, let's merge it!
Follow up to #555, this PR implements a forge data decoder.