Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog update and include test for #1095 #1109

Merged
merged 1 commit into from
Feb 10, 2024

Conversation

andersonhc
Copy link
Collaborator

e.g. Fixes #0

Checklist:

  • The GitHub pipeline is OK (green),
    meaning that both pylint (static code analyzer) and black (code formatter) are happy with the changes of this PR.

  • A unit test is covering the code added / modified by this PR

  • This PR is ready to be merged

  • In case of a new feature, docstrings have been added, with also some documentation in the docs/ folder

  • A mention of the change is present in CHANGELOG.md

By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3718231) 93.41% compared to head (2e657c3) 93.41%.
Report is 2 commits behind head on master.

❗ Current head 2e657c3 differs from pull request most recent head 75bac40. Consider uploading reports for the commit 75bac40 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1109   +/-   ##
=======================================
  Coverage   93.41%   93.41%           
=======================================
  Files          30       30           
  Lines        9113     9117    +4     
  Branches     2068     2070    +2     
=======================================
+ Hits         8513     8517    +4     
  Misses        371      371           
  Partials      229      229           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andersonhc andersonhc merged commit f03b3b1 into py-pdf:master Feb 10, 2024
11 checks passed
@andersonhc andersonhc deleted the tests-for-#1095 branch February 11, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants