Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ln() before text uses font_htight, fixes #937 #940

Merged
merged 3 commits into from
Oct 3, 2023

Conversation

gmischler
Copy link
Collaborator

@gmischler gmischler commented Oct 3, 2023

e.g. Fixes #937
Checklist:

  • The GitHub pipeline is OK (green),
    meaning that both pylint (static code analyzer) and black (code formatter) are happy with the changes of this PR.
  • A unit test is covering the code added / modified by this PR
  • This PR is ready to be merged
  • In case of a new feature, docstrings have been added, with also some documentation in the docs/ folder
  • A mention of the change is present in CHANGELOG.md

The modified test files typically use a ln() in a loop.

By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.

@gmischler
Copy link
Collaborator Author

gmischler commented Oct 3, 2023

Apparently a new pylint version has removed 'implicit-str-concat' from the defaults...

edit:
Alright, so apparently just the rules have changed:
Implicit concatenation is considered ok when the strings are the only thing between a set of parens.
I just fixed all instances in this manner, removed the respective pylint control comments, and packed that chance onto this PR.

@gmischler
Copy link
Collaborator Author

Ok, so since this is quite a trivial change which has already been discussed in #937, it passes all the tests (except for the silly large-text timing), and the pylint related changes will help all other PRs to pass their tests, I'm not going to wait for reviews and just send it.

@gmischler gmischler merged commit 30eb1a4 into py-pdf:master Oct 3, 2023
8 of 10 checks passed
@gmischler gmischler deleted the initial-nl branch October 3, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ln() does nothing at the beginning of a new file
1 participant