-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: Adding unit tests #28
Conversation
@MartinThoma: I think you added a dependency to But this dependency was not declared in https://github.com/py-pdf/pdfly/blob/main/pyproject.toml#L31 Which is why the unit tests are currently failing in the GitHub Actions pipeline:
If you agree, I can add |
16278cd
to
bd9134a
Compare
@Lucas-C Thank you for the many improvements 🙏 The PR looks awesome 🎉 One last question before we merge it: Where do the images come from? |
The images come from https://github.com/py-pdf/fpdf2/tree/master/test/image/image_types: |
Very nice! Thank you 🙏 |
Thank you! Now I'll have to fix those We could also open issues with the |
I like the idea of inviting new contributors :-) I would need to check what is required by us if we do that. I have no idea. |
I added a few issues with the |
## What's new ### New Features (ENH) - Add x2pdf command (#25) by @MartinThoma ### Bug Fixes (BUG) - boxes are floats, not int by @MartinThoma - Add missing fpdf2 dependency (#29) by @MartinThoma ### Documentation (DOC) - cat command by @MartinThoma - More examples for the cat subcommand by @MartinThoma - Add cat subcommand by @MartinThoma - Link to readthedocs by @MartinThoma - Add project governance file by @MartinThoma - Move readthedocs config file to root by @MartinThoma - Add docs (#24) by @MartinThoma ### Developer Experience (DEV) - Checkout sample-files in CI (#30) by @MartinThoma - Let dependabot update Github Actions by @MartinThoma - Add action for automatic releases by @MartinThoma ### Maintenance (MAINT) - Update dependencies (#42) by @MartinThoma - In the cat subcommand, replace the usage of the deprecated PdfMerger by PdfWriter (#34) by @kommade - Update .pre-commit-config.yaml by @MartinThoma - Adjust x2pdf syntax by @MartinThoma ### Testing (TST) - cat with two files (#41) by @MartinThoma - Test cat command with more parameters + validate result (#40) by @MartinThoma - Adding unit tests (#28) by @Lucas-C [Full Changelog](0.2.14...0.3.0)
I introduced the unit tests I originally developped in py-pdf/pypdf#2170
I also added a
pytest -vv
execution as part of the GitHub Actions pipeline