Skip to content

Add link to fpdf2 + .id on headings in maintainer-guidelines.md #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2023

Conversation

Lucas-C
Copy link
Member

@Lucas-C Lucas-C commented Aug 13, 2023

I used a small JS <script> that I have been using for a while in order to create "linkable" headings on this page,
in order for the table of content to work: https://py-pdf.github.io/pages/maintainer-guidelines.html

@MartinThoma MartinThoma self-requested a review August 13, 2023 14:55
@Lucas-C Lucas-C force-pushed the add-fpdf2 branch 6 times, most recently from be85e12 to 8774ea6 Compare August 13, 2023 15:49
@Lucas-C Lucas-C merged commit 0657815 into main Aug 13, 2023
@Lucas-C Lucas-C deleted the add-fpdf2 branch August 13, 2023 15:54
@Lucas-C
Copy link
Member Author

Lucas-C commented Aug 13, 2023

@MartinThoma: I disabled the Require signed commits setting on this repository in order to merge this PR.

The issue that I have is that:

  • I use an anonymized git user.email for my commits (which BTW is required by the repo / org settings), provided by GitHub: 925560+Lucas-C@users.noreply.github.com
  • my GPG key does not include this anonymized GitHub email address, only my own my personal address. This leads to my commits being signed, but GitHub considering them to be "Unverified", as the signature does not match the commit author email address

The only "clean" solution would be for me to re-generate a new GPG signing key that includes my Gitlab & GitHub anonymized email address, but I won't undertake this task now.

Is this OK with you or do you really wish for all commits to be signed on this repository?

@Lucas-C
Copy link
Member Author

Lucas-C commented Aug 13, 2023

By the way, how is the website published? https://py-pdf.github.io/

This does not seem automated through GitHub Actions when new commits land on the main branch:
https://github.com/py-pdf/py-pdf.github.io/actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants