Skip to content

Commit

Permalink
MAINT: Bring add_bookmark_dict and add_bookmark_destination together
Browse files Browse the repository at this point in the history
See #1098
  • Loading branch information
MartinThoma committed Jul 12, 2022
1 parent 8f47939 commit b52c3d5
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions PyPDF2/_writer.py
Original file line number Diff line number Diff line change
Expand Up @@ -1057,17 +1057,17 @@ def getNamedDestRoot(self) -> ArrayObject: # pragma: no cover
def add_bookmark_destination(
self, dest: PageObject, parent: Optional[TreeObject] = None
) -> IndirectObject:
dest_ref = self._add_object(dest)
bookmark_ref = self._add_object(dest)

outline_ref = self.get_outline_root()

if parent is None:
parent = outline_ref

parent = cast(TreeObject, parent.get_object())
parent.add_child(dest_ref, self)
parent.add_child(bookmark_ref, self)

return dest_ref
return bookmark_ref

def addBookmarkDestination(
self, dest: PageObject, parent: Optional[TreeObject] = None
Expand Down Expand Up @@ -1103,8 +1103,7 @@ def add_bookmark_dict(
if parent is None:
parent = outline_ref

parent = parent.get_object() # type: ignore
assert parent is not None, "hint for mypy"
parent = cast(TreeObject, parent.get_object())
parent.add_child(bookmark_ref, self)

return bookmark_ref
Expand Down

0 comments on commit b52c3d5

Please sign in to comment.