Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

text_extraction invalid for habibi.pdf #1619

Closed
pubpub-zz opened this issue Feb 8, 2023 · 2 comments · Fixed by #1620
Closed

text_extraction invalid for habibi.pdf #1619

pubpub-zz opened this issue Feb 8, 2023 · 2 comments · Fixed by #1620
Labels
is-bug From a users perspective, this is a bug - a violation of the expected behavior with a compliant PDF

Comments

@pubpub-zz
Copy link
Collaborator 

          I've opened https://github.com/py-pdf/sample-files/pull/13 to put `habibi.pdf` in the sample-files repo.  i recommend including a test for it before merging this.

the extracted show the arab characters to be reversed

Originally posted by @dkg in #1126 (comment)
@pubpub-zz
Copy link
Collaborator Author

@dkg
thanks for the sample :)

pubpub-zz added a commit to pubpub-zz/pypdf that referenced this issue Feb 8, 2023
@pubpub-zz
BUG : Text extaction not working with one gliph to char sequence
fe40441 
fixes py-pdf#1619
@pubpub-zz pubpub-zz mentioned this issue Feb 8, 2023
Merged
@pubpub-zz pubpub-zz changed the title I've opened https://github.com/py-pdf/sample-files/pull/13 to put habibi.pdf in the sample-files repo. i recommend including a test for it before merging this. text_extraction invalid for habibi.pdf Feb 8, 2023
@pubpub-zz pubpub-zz added is-bug From a users perspective, this is a bug - a violation of the expected behavior with a compliant PDF soon PRs that are almost ready to be merged, issues that get solved pretty soon labels Feb 8, 2023
MartinThoma pushed a commit that referenced this issue Feb 10, 2023
@pubpub-zz
BUG: Text extraction not working with one glyph to char sequence (#1620)
f5ac79b 
Fixes #1619
@MartinThoma
Copy link
Member

Thank you for the improvement @pubpub-zz 🙏

I'll make a release this weekend :-)

@MartinThoma MartinThoma removed the soon PRs that are almost ready to be merged, issues that get solved pretty soon label Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
is-bug From a users perspective, this is a bug - a violation of the expected behavior with a compliant PDF
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BUG: Text extraction not working with one glyph to char sequence pubpub-zz/pypdf
2 participants
@MartinThoma @pubpub-zz