Sample_Code, Scripts and Tests are wrongly installed as top-level packages

[mgorny]

The 2.7.2 release includes a regression where additional top-level packages are wrongly installed, e.g.:

/usr/lib/python3.10/site-packages/Sample_Code
/usr/lib/python3.10/site-packages/Scripts
/usr/lib/python3.10/site-packages/Tests

If these files are really supposed to be installed, they should be inside PyPDF2 and not at top level.

[MartinThoma]

I'm pretty confused by that. This is how the diff between 1.26.0 and 1.27.2 looks like (of the source package):

I've added Scripts, Sample_Code, and Tests because I have seen that they were present before. I don't know how they were added before, because they were neither in the Manifest nor there as packages.

Is this currently causing issues?

• I want to remove Sample_Code soon completely, see: MAINT: Remove Sample_Code #726
• I don't like the Tests and Resources being added either and I have a hard time imagining that removing them would cause any trouble
• Scripts ... here I'm not sure how I should continue. Either I add them as a sub-package or I remove it. Is there another option?

[MartinThoma]

When I add it just to the manifest and not as a package, would that lead to the desired result?

[mgorny]

I've added Scripts, Sample_Code, and Tests because I have seen that they were present before. I don't know how they were added before, because they were neither in the Manifest nor there as packages.

Yes, I suppose it makes sense to include them in sdist but they shouldn't be installed into site-packages. I'm afraid I can't help you figuring out why it worked before, setuptools sdist magic was always totally confusing to me (and I've seen that with my own packages too) but…

When I add it just to the manifest and not as a package, would that lead to the desired result?

…yes, I think adding these directories to MANIFEST.in should achieve the desired result without causing them to be installed.

[MartinThoma]

I've just tried it out locally. Seems to do what is expected. I will make a release today (but probably not within the next 2 hours ... might be in the evening).

[mgorny]

Ok, thanks!

[mgorny]

I can confirm that 1.27.3 looks fine.