Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Use add_bookmark_destination in add_bookmark #1100

Merged
merged 4 commits into from
Jul 12, 2022
Merged

Conversation

MartinThoma
Copy link
Member

Reduce code duplication

See #1098

@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #1100 (5fab630) into main (d7b64dc) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1100      +/-   ##
==========================================
- Coverage   91.60%   91.59%   -0.01%     
==========================================
  Files          24       24              
  Lines        4538     4533       -5     
  Branches      932      932              
==========================================
- Hits         4157     4152       -5     
  Misses        241      241              
  Partials      140      140              
Impacted Files Coverage Δ
PyPDF2/_writer.py 88.97% <100.00%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7b64dc...5fab630. Read the comment docs.

@MartinThoma MartinThoma merged commit c420beb into main Jul 12, 2022
@MartinThoma MartinThoma deleted the sty-add-bookmark branch July 12, 2022 06:21
mtd91429 pushed a commit to mtd91429/PyPDF2 that referenced this pull request Jul 15, 2022
MartinThoma added a commit that referenced this pull request Jul 17, 2022
New Features (ENH):
-  Add color and font_format to PdfReader.outlines[i] (#1104)
-  Extract Text Enhancement (whitespaces) (#1084)

Bug Fixes (BUG):
-  Use `build_destination` for named destination outlines (#1128)
-  Avoid a crash when a ToUnicode CMap has an empty dstString in beginbfchar (#1118)
-  Prevent deduplication of PageObject (#1105)
-  None-check in DictionaryObject.read_from_stream (#1113)
-  Avoid IndexError in _cmap.parse_to_unicode (#1110)

Documentation (DOC):
-  Explanation for git submodule
-  Watermark and stamp (#1095)

Maintenance (MAINT):
-  Text extraction improvements (#1126)
-  Destination.color returns ArrayObject instead of tuple as fallback (#1119)
-  Use add_bookmark_destination in add_bookmark (#1100)
-  Use add_bookmark_destination in add_bookmark_dict (#1099)

Testing (TST):
-  Remove xfail from test_outline_title_issue_1121
-  Add test for arab text (#1127)
-  Add xfail for decryption fail (#1125)
-  Add xfail test for IndexError when extracting text (#1124)
-  Add MCVE showing outline title issue (#1123)

Code Style (STY):
-  Apply black and isort
-  Use IntFlag for permissions_flag / update_page_form_field_values (#1094)
-  Simplify code (#1101)

Full Changelog: 2.5.0...2.6.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant