Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: u_hash in AlgV4.compute_key #1170

Merged
merged 2 commits into from
Jul 25, 2022
Merged

BUG: u_hash in AlgV4.compute_key #1170

merged 2 commits into from
Jul 25, 2022

Conversation

exiledkingcc
Copy link
Contributor

@exiledkingcc exiledkingcc commented Jul 25, 2022 •
edited by MartinThoma
Loading

Closes #1088

@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #1170 (1e7b324) into main (0b27287) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1170      +/-   ##
==========================================
+ Coverage   92.24%   92.29%   +0.04%     
==========================================
  Files          24       24              
  Lines        4811     4812       +1     
  Branches      991      991              
==========================================
+ Hits         4438     4441       +3     
+ Misses        231      230       -1     
+ Partials      142      141       -1
Impacted Files Coverage Δ
PyPDF2/_encryption.py 85.98% <100.00%> (+0.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b27287...1e7b324. Read the comment docs.

@MartinThoma MartinThoma changed the title fix 1088: correct BooleanObject compare BUG: AlgV4.compute_key Jul 25, 2022
@MartinThoma MartinThoma changed the title BUG: AlgV4.compute_key BUG: u_hash in AlgV4.compute_key Jul 25, 2022
@MartinThoma MartinThoma merged commit 3b73b34 into py-pdf:main Jul 25, 2022
@MartinThoma
Copy link
Member

Thank you 🤗

MartinThoma added a commit that referenced this pull request Jul 25, 2022
@MartinThoma
REL: 2.8.1
5b75160 
Bug Fixes (BUG):
-  u_hash in AlgV4.compute_key (#1170)

Robustness (ROB):
-  Fix loading of file from #134 (#1167)
-  Cope with empty DecodeParams (#1165)

Documentation (DOC):
-  Typo in warning message (#1166)

Maintenance (MAINT):
-  Package updates; solve mypy strict remarks (#1163)

Testing (TST):
-  Add test from #325 (#1169)

Full Changelog: 2.8.0...2.8.1
@exiledkingcc exiledkingcc deleted the fix-1088 branch July 26, 2022 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PdfReadError: File has not been decrypted
2 participants
@exiledkingcc @MartinThoma