Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add rotation property and transfer_rotate_to_content #1348

Merged
merged 7 commits into from
Sep 17, 2022

Conversation

pubpub-zz
Copy link
Collaborator

refer to #1280 for history

@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Base: 94.63% // Head: 94.71% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (8ccf984) compared to base (7c96d13).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1348      +/-   ##
==========================================
+ Coverage   94.63%   94.71%   +0.08%     
==========================================
  Files          30       30              
  Lines        5140     5181      +41     
  Branches     1058     1060       +2     
==========================================
+ Hits         4864     4907      +43     
  Misses        164      164              
+ Partials      112      110       -2     
Impacted Files Coverage Δ
PyPDF2/_page.py 95.00% <100.00%> (+0.60%) ⬆️
PyPDF2/generic/_rectangle.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pubpub-zz
Copy link
Collaborator Author

@MartinThoma
ready for review 😊

PyPDF2/_page.py Outdated Show resolved Hide resolved
Co-authored-by: Martin Thoma <info@martin-thoma.de>
PyPDF2/_page.py Outdated Show resolved Hide resolved
@MartinThoma MartinThoma changed the title ENH : add rotation and transfer_rotate_to_content ENH: Add rotation property and transfer_rotate_to_content Sep 17, 2022
PyPDF2/_page.py Outdated Show resolved Hide resolved
@MartinThoma MartinThoma merged commit 71de6c8 into py-pdf:main Sep 17, 2022
MartinThoma added a commit that referenced this pull request Sep 18, 2022
New Features (ENH):
-  Add rotation property and transfer_rotate_to_content (#1348)

Performance Improvements (PI):
-  Avoid string concatenation with large embedded base64-encoded images (#1350)

Bug Fixes (BUG):
-  Format floats using their intrinsic decimal precision (#1267)

Robustness (ROB):
-  Fix merge_page for pages without resources (#1349)

Full Changelog: 2.10.8...2.10.9
@pubpub-zz pubpub-zz deleted the rotation branch June 24, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants