TST: read_string_from_stream performance #1355
Conversation
There is a saftey margin of a factor of 10 in both directions, so the test should be fairly stable. Tests py-pdf#1350.
|
Hello @MartinThoma, i did manage to create a test-pdf (attached to #1350), but ended up writing a more minimal unit test. Would you prefer a test with that test-pdf, or do you prefer this unit test? cheers edit: 😬 ok turns out the safety-margin was not enough to make the test stable. It took 2.8 seconds on the build agent. I am not convinced this test helps more than it hurts... |
Codecov ReportBase: 94.71% // Head: 94.71% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1355 +/- ##
=======================================
Coverage 94.71% 94.71%
=======================================
Files 30 30
Lines 5185 5185
Branches 1061 1061
=======================================
Hits 4911 4911
Misses 164 164
Partials 110 110 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
MartinThoma
changed the title
New Features (ENH): - Addition of optional visitor-functions in extract_text() (#1252) - Add metadata.creation_date and modification_date (#1364) - Add PageObject.images attribute (#1330) Bug Fixes (BUG): - Lookup index in _xobj_to_image can be ByteStringObject (#1366) - \'IndexError: index out of range\' when using extract_text (#1361) - Errors in transfer_rotation_to_content() (#1356) Robustness (ROB): - Ensure update_page_form_field_values does not fail if no fields (#1346) Testing (TST): - read_string_from_stream performance (#1355) Full Changelog: 2.10.9...2.11.0
There is a saftey margin of a factor of 10 in both directions, so the test should be fairly stable. Tests #1350.