Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Use Ubuntu 20.04 for running CI test suite #1452

Merged
merged 1 commit into from
Nov 23, 2022
Merged

Conversation

MasterOdin
Copy link
Member

Closes #1451

This sets the test suite to use ubuntu-20.04 as opposed to ubuntu-latest as the latter switched over in the last day or so to using ubuntu-22.04 and that broke testing Python 3.6. Ubuntu 20.04 has maintenance fixes for another ~2.5 years, and is supported critically for another 5 years after that, so the OS itself should be fine until we drop support for Python 3.6, and could then switch to ubuntu-22.04. It's also possible that the latter image will become compatible with Python 3.6 as well, but who knows.

Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Base: 94.25% // Head: 94.30% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (542595c) compared to base (fb34775).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1452      +/-   ##
==========================================
+ Coverage   94.25%   94.30%   +0.05%     
==========================================
  Files          28       28              
  Lines        5096     5143      +47     
  Branches      973      973              
==========================================
+ Hits         4803     4850      +47     
  Misses        177      177              
  Partials      116      116              
Impacted Files Coverage Δ
PyPDF2/generic/_base.py 100.00% <0.00%> (ø)
PyPDF2/generic/_utils.py 100.00% <0.00%> (ø)
PyPDF2/filters.py 97.29% <0.00%> (+0.01%) ⬆️
PyPDF2/_reader.py 89.61% <0.00%> (+0.03%) ⬆️
PyPDF2/_encryption.py 92.66% <0.00%> (+0.04%) ⬆️
PyPDF2/generic/_data_structures.py 95.11% <0.00%> (+0.04%) ⬆️
PyPDF2/_page.py 92.22% <0.00%> (+0.05%) ⬆️
PyPDF2/xmp.py 92.10% <0.00%> (+0.97%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MartinThoma MartinThoma merged commit 420a545 into main Nov 23, 2022
@MartinThoma MartinThoma deleted the MasterOdin-patch-1 branch November 23, 2022 08:12
@MartinThoma
Copy link
Member

Thank you for taking care of it 🙏

MartinThoma added a commit that referenced this pull request Dec 10, 2022
New Features (ENH):
-  Add support to extract gray scale images (#1460)
-  Add 'threads' property to PdfWriter (#1458)
-  Add 'open_destination' property to PdfWriter (#1431)
-  Make PdfReader.get_object accept integer arguments (#1459)

Bug Fixes (BUG):
-  Scale PDF annotations (#1479)

Robustness (ROB):
-  Padding issue with AES encryption (#1469)
-  Accept empty object as null objects (#1477)

Documentation (DOC):
-  Add module documentation the PaperSize class (#1447)

Maintenance (MAINT):
-  Use 'page_number' instead of 'pagenum' (#1365)
-  Add List of pages to PageRangeSpec (#1456)

Testing (TST):
-  Cleanup temporary files (#1454)
-  Mark test_tounicode_is_identity as external (#1449)
-  Use Ubuntu 20.04 for running CI test suite (#1452)

[Full Changelog](2.11.2...2.12.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.6 in CI
2 participants