ENH: Accept hierarchical fields #1529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 91.83% // Head: 91.79% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1529 +/- ##
==========================================
- Coverage 91.83% 91.79% -0.04%
==========================================
Files 33 33
Lines 6073 6093 +20
Branches 1193 1200 +7
==========================================
+ Hits 5577 5593 +16
- Misses 321 323 +2
- Partials 175 177 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
MartinThoma
added
workflow-forms
MartinThoma
changed the title
MartinThoma
reviewed
Jan 5, 2023
indexed names implemented with . not _ (possible mix up with names
MartinThoma
reviewed
Jan 6, 2023
|
@MartinThoma |
MartinThoma
reviewed
Jan 7, 2023
MartinThoma
reviewed
Jan 7, 2023
|
Overall, the PR looks good to me :-) I will have another look tomorrow, but if it's only those minor stylistic things, I can also fix them after merging :-) Good work @pubpub-zz 👍 🙏 |
Co-authored-by: Martin Thoma <info@martin-thoma.de>
MartinThoma
added a commit
that referenced
this pull request
Jan 8, 2023
New Features (ENH): - Accept hierarchical fields (#1529) Documentation (DOC): - Use google style docstrings (#1534) - Fix linked markdown documents (#1537) Developer Experience (DEV): - Update docs config (#1535) [Full Changelog](3.2.0...3.2.1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1468
Add an optional parameter to
get_form_text_fieldsTBC : behavior with multiple fields with same name create sequence _2, _3, ... does not seem to be applied
Pending : Test to be added