Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Generate static appearance for fields #1864

Merged
merged 24 commits into from
Jun 11, 2023

Conversation

pubpub-zz
Copy link
Collaborator

Create/Update AP entries to not require Need_appearances flags

closes #1306

@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Patch coverage: 95.65% and project coverage change: +0.24 🎉

Comparison is base (1f114ba) 93.53% compared to head (557004d) 93.77%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1864      +/-   ##
==========================================
+ Coverage   93.53%   93.77%   +0.24%     
==========================================
  Files          34       34              
  Lines        6625     6720      +95     
  Branches     1296     1320      +24     
==========================================
+ Hits         6197     6302     +105     
+ Misses        281      272       -9     
+ Partials      147      146       -1     
Impacted Files Coverage Δ
pypdf/_writer.py 88.75% <94.11%> (+0.93%) ⬆️
pypdf/_reader.py 91.33% <95.83%> (+0.05%) ⬆️
pypdf/constants.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pubpub-zz
Copy link
Collaborator Author

@MartinThoma
ready for review

pypdf/_writer.py Outdated Show resolved Hide resolved
@MartinThoma
Copy link
Member

I have two suggestions to improve readability. Besides that, it looks good to me 👍 :-)

@MartinThoma MartinThoma added soon PRs that are almost ready to be merged, issues that get solved pretty soon workflow-forms From a users perspective, forms is the affected feature/workflow labels Jun 11, 2023
Co-authored-by: Martin Thoma <info@martin-thoma.de>
pubpub-zz and others added 2 commits June 11, 2023 10:40
Co-authored-by: Martin Thoma <info@martin-thoma.de>
pypdf/_writer.py Outdated Show resolved Hide resolved
pypdf/_writer.py Outdated Show resolved Hide resolved
pypdf/_writer.py Outdated Show resolved Hide resolved
pypdf/_writer.py Outdated Show resolved Hide resolved
pypdf/_writer.py Outdated Show resolved Hide resolved
Avoiding abbreviations in public interfaces makes it easier for non-native speakers
tests/test_writer.py Outdated Show resolved Hide resolved
@MartinThoma MartinThoma merged commit b128846 into py-pdf:main Jun 11, 2023
@MartinThoma MartinThoma removed the soon PRs that are almost ready to be merged, issues that get solved pretty soon label Jun 11, 2023
@MartinThoma MartinThoma changed the title BUG : Generate static apparearance for fields BUG: Generate static appearance for fields Jun 11, 2023
MartinThoma added a commit that referenced this pull request Jun 18, 2023
New Features (ENH):
-  Extraction of inline images (#1850)
-  Add capability to replace image (#1849)
-  Extend images interface by returning an ImageFile(File) class (#1848)
-  Add set_data to EncodedStreamObject (#1854)

Bug Fixes (BUG):
-  Fix RGB FlateEncode Images(PNG) and transparency (#1834)
-  Generate static appearance for fields (#1864)

[Full Changelog](3.9.1...3.10.0)
@pubpub-zz pubpub-zz deleted the create_field_app branch September 2, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workflow-forms From a users perspective, forms is the affected feature/workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update_page_form_field_values prevents barcode (pdf417) from displaying correctly
2 participants