Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: Install pytest-socket in tox #1885

Merged
merged 1 commit into from
Jun 14, 2023
Merged

MAINT: Install pytest-socket in tox #1885

merged 1 commit into from
Jun 14, 2023

Conversation

adamchainz
Copy link
Contributor

I found this was required to run the tests with tox in #1884.

@MartinThoma MartinThoma changed the title Install pytest-socket in tox MAINT: Install pytest-socket in tox Jun 14, 2023
@MartinThoma MartinThoma added the is-maintenance Anything that is just internal: Simplifying code, syntax changes, updating docs, speed improvements label Jun 14, 2023
@MartinThoma MartinThoma merged commit 243c184 into py-pdf:main Jun 14, 2023
@MartinThoma
Copy link
Member

Thank you :-)

If you want, I can add you as a contributor: https://pypdf.readthedocs.io/en/latest/meta/CONTRIBUTORS.html

@adamchainz adamchainz deleted the fix_tox branch June 14, 2023 21:12
@adamchainz
Copy link
Contributor Author

I don't really mind, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
is-maintenance Anything that is just internal: Simplifying code, syntax changes, updating docs, speed improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamchainz @MartinThoma