Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Adjust type annotations in _rectangle.py #1920

Merged
merged 2 commits into from
Jun 26, 2023
Merged

MAINT: Adjust type annotations in _rectangle.py #1920

merged 2 commits into from
Jun 26, 2023

Conversation

postmeback
Copy link
Contributor

@postmeback postmeback commented Jun 26, 2023

The setters lower_left / lower_right / upper_left / upper_right are now consistent with the getters.

Closes #1842

Updated the content as mentioned #1842
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (7b357c7) 92.83% compared to head (91aba9e) 92.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1920   +/-   ##
=======================================
  Coverage   92.83%   92.83%           
=======================================
  Files          34       34           
  Lines        7058     7058           
  Branches     1389     1389           
=======================================
  Hits         6552     6552           
  Misses        359      359           
  Partials      147      147           
Impacted Files Coverage Δ
pypdf/generic/_rectangle.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

`List` removed from import
@py-pdf py-pdf deleted a comment from postmeback Jun 26, 2023
@MartinThoma MartinThoma changed the title Update _rectangle.py MAINT: Adjust type annotations in _rectangle.py Jun 26, 2023
@MartinThoma MartinThoma merged commit 2491783 into py-pdf:main Jun 26, 2023
@MartinThoma
Copy link
Member

Well done, congratulations to your first merged PR! The update will go life latest on Sunday in the next release.

If you want, I can add you to https://pypdf.readthedocs.io/en/latest/meta/CONTRIBUTORS.html

@MartinThoma
Copy link
Member

You might have noticed a few adjustments I made in this PR:

The title of the PR typically becomes the first line in the squashed commit message. The body becomes the rest of the commit message.

@postmeback
Copy link
Contributor Author

Sure, please add me. @MartinThoma

MartinThoma added a commit that referenced this pull request Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API inconsistency in RectangleObject?
2 participants