Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Dates conversion not working with Z00'00' #1946

Merged
merged 2 commits into from
Jul 6, 2023

Conversation

pubpub-zz
Copy link
Collaborator

closes #1943

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: +0.02 🎉

Comparison is base (29c79fc) 93.89% compared to head (49f0577) 93.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1946      +/-   ##
==========================================
+ Coverage   93.89%   93.92%   +0.02%     
==========================================
  Files          33       33              
  Lines        6983     6983              
  Branches     1382     1382              
==========================================
+ Hits         6557     6559       +2     
+ Misses        274      273       -1     
+ Partials      152      151       -1     
Impacted Files Coverage Δ
pypdf/_reader.py 91.53% <66.66%> (+0.19%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pubpub-zz
Copy link
Collaborator Author

@MartinThoma
all yours

@MartinThoma MartinThoma changed the title BUG : Dates conversion not working with Z00'00' BUG: Dates conversion not working with Z00'00' Jul 6, 2023
@MartinThoma MartinThoma merged commit c239073 into py-pdf:main Jul 6, 2023
11 of 12 checks passed
@MartinThoma
Copy link
Member

Thanks for the fix!

MartinThoma added a commit that referenced this pull request Jul 9, 2023
Bug Fixes (BUG):
-  Prevent updating page contents after merging page (stamping/watermarking) (#1952)
-  % to be hex encoded in names (#1958)
-  Inverse color in CMYK images (#1947)
-  Dates conversion not working with Z00\'00\' (#1946)
-  Support UTF-16-LE Strings (#1884)

[Full Changelog](3.12.0...3.12.1)
MartinThoma added a commit that referenced this pull request Jul 9, 2023
Bug Fixes (BUG):
-  Prevent updating page contents after merging page (stamping/watermarking) (#1952)
-  % to be hex encoded in names (#1958)
-  Inverse color in CMYK images (#1947)
-  Dates conversion not working with Z00\'00\' (#1946)
-  Support UTF-16-LE Strings (#1884)

[Full Changelog](3.12.0...3.12.1)
@pubpub-zz pubpub-zz deleted the iss1943 branch September 2, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Read metadata Error: CreationDate & ModDate
2 participants