DOC: Link to CONTRIBUTING.md in README.md #2232
Conversation
Added link to CONTRIBUTING.md in the "Contributions" section and added common questions and answers in the Q&A section.
|
Where do these FAQ come from? If ever, shouldn't these rather be part of the official docs instead of the README? Additionally, the |
README.md
Outdated
|
|
||
| **How can I use pypdf to merge pdf files?** | ||
|
|
||
| Use the <code>PdfMerger</code> class. The <code>append</code> method is great for simply concatenating files, but <code>merge</code> can be used |
There was a problem hiding this comment.
PdfMerger is obsolete. PdfWriter has to be used instead
README.md
Outdated
|
|
||
| **How can I extract text from a pdf?** | ||
|
|
||
| There are several ways of extracting text from a pdf file using pypdf. The <code>extractText</code> method is likely the simplest way of doing this. |
There was a problem hiding this comment.
link to the proper documentation page should be added
|
The link to CONTRIBUTING is fine. Please remove the rest. |
MartinThoma
changed the title
|
@MartinThoma Have you consiredered my comments ? |
|
@pubpub-zz I have removed those parts from the PR as they are already covered in a cleaner way in the very top of the README. Did I miss something? |
|
all good, I was just questionning based on the replies to my comments. |
|
I do agree to your comments 👍 But I also think we should not add any of the paragraphs you commented on, hence they are not relevant any longer. |
## What's new ### Bug Fixes (BUG) - invalid cm/tm in visitor functions (#2206) by @pubpub-zz - Encrypt / decrypt Stream object dictionaries (#2228) by @pilotandy - Support nested color spaces for the /DeviceN color space (#2241) by @Stefan - images property fails if NullObject in list (#2215) by @pubpub-zz ### Robustness (ROB) - XYZ destination to cope with missing left and top param (#2237) by @pubpub-zz ### Documentation (DOC) - Add pilotandy for #2228 as a contributor by @MartinThoma - Link to CONTRIBUTING.md in README.md (#2232) by @markpfeifle - Changelog by @MartinThoma ### Developer Experience (DEV) - Exclude tests from mypy checks by @MartinThoma - Unify mypy options and warn redundant workarounds (#2223) by @exiledkingcc - Stabilize Pillow test with Pillow missing (#2229) by @Stefan ### Maintenance (MAINT) - Update pinned packages (#2243) by @MartinThoma ### Testing (TST) - Regression test against non-deterministic accidental object reuse (#2244) by @MartinThoma [Full Changelog](3.16.2...3.16.3)
Added link to CONTRIBUTING.md in the "Contributions" section and added three common questions and answers in the Q&A section.