Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Add feature support by pypdf #2738

Merged
merged 11 commits into from
Jul 17, 2024
Merged

DOC: Add feature support by pypdf #2738

merged 11 commits into from
Jul 17, 2024

Conversation

j-t-1
Copy link
Contributor

@j-t-1 j-t-1 commented Jul 3, 2024

No description provided.

j-t-1 added 3 commits July 3, 2024 12:17
Add ticks for Cross-reference Streams and Content Stream Compression
Plus a tiny change to a comment in test_name_object.
Plus a tiny change to a comment in test_name_object.
@j-t-1 j-t-1 changed the title Features DOC: Add feature support by pypdf Jul 3, 2024
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.14%. Comparing base (6ef6d7e) to head (03a8ac8).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2738   +/-   ##
=======================================
  Coverage   95.14%   95.14%           
=======================================
  Files          51       51           
  Lines        8547     8547           
  Branches     1703     1703           
=======================================
  Hits         8132     8132           
  Misses        261      261           
  Partials      154      154           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefan6419846
Copy link
Collaborator

What is the data based upon?

@j-t-1
Copy link
Contributor Author

j-t-1 commented Jul 3, 2024

Content stream compression is provided by function compress_content_streams.
Cross-reference streams, do we support this? I will revert the tick.

@stefan6419846
Copy link
Collaborator

I will wait for @pubpub-zz to check if these statements are valid, having more knowledge on PDF files and specific stuff of pypdf.

@pubpub-zz
Copy link
Collaborator

Cross Reference streams are defined in §3.4.7of pdf 1.7 reference. They are tagged with XRefStm

It allows many objects to be stored within a stream which may improve compression.

pypdf can read them without problem. I can not remember any functions allowing to modify/create some.

docs/user/pdf-version-support.md Outdated Show resolved Hide resolved
docs/user/pdf-version-support.md Outdated Show resolved Hide resolved
docs/user/pdf-version-support.md Outdated Show resolved Hide resolved
@j-t-1
Copy link
Contributor Author

j-t-1 commented Jul 6, 2024

Thanks @pubpub-zz. Content Stream Compression support is now the added supported feature.

@j-t-1
Copy link
Contributor Author

j-t-1 commented Jul 8, 2024

I have reverted this so that the pypdf supported features is unchanged, so this is now just a cosmetic improvement.

@stefan6419846
Copy link
Collaborator

Why did you revert this? Apparently, the table has been outdated, thus I would recommend to update it. Just replacing the plain text symbols by emojis is not really something I would consider worth to change.

Add content stream compression support. Sort rows first by PDF Version and then by Feature.
@j-t-1
Copy link
Contributor Author

j-t-1 commented Jul 8, 2024

Reverted the revert.

@stefan6419846
Copy link
Collaborator

It seems like the revert did too much - #2738 (review) should be included.

@stefan6419846 stefan6419846 merged commit 0da2f5d into py-pdf:main Jul 17, 2024
16 checks passed
@j-t-1 j-t-1 deleted the features branch July 17, 2024 15:42
MartinThoma added a commit that referenced this pull request Jul 21, 2024
## What's new

### Bug Fixes (BUG)
- Cope with Matrix entry in field annotations (#2736)

### Robustness (ROB)
- Cope with fields with upside down box/rectangle (#2729) by @pubpub-zz

### Documentation (DOC)
- Update Link Documentation Example (#2759) by @jparris
- Make table consistent with pdf-version-support.md (#2758) by @j-t-1
- Add feature support by pypdf (#2738) by @j-t-1
- Move JavaScript example (#2746) by @j-t-1
- Added example for downloading a PDF from Google Cloud Storage  (#2745) by @prodeveloper
- Miscellaneous tiny changes (#2744) by @j-t-1
- Amend comment with rectangle duplication (#2733) by @j-t-1
- Use enumerate in extract example (#2727) by @j-t-1
- Tiny changes (#2723) by @j-t-1

### Maintenance (MAINT)
- Remove redundant pass statement (#2739) by @j-t-1
- Update Python version support documentation (#2740) by @j-t-1
- Remove redundant super() (#2734) by @j-t-1
- Add deprecate_with_replacement to StreamObject.initializeFromD… (#2728) by @j-t-1

### Code Style (STY)
- Change argument type (#2741) by @j-t-1
- Use endswith instead of logical equals (#2732) by @j-t-1

[Full Changelog](4.3.0...4.3.1)
@MartinThoma MartinThoma mentioned this pull request Jul 21, 2024
stefan6419846 pushed a commit that referenced this pull request Jul 21, 2024
## What's new

### Bug Fixes (BUG)
- Cope with Matrix entry in field annotations (#2736) by @pubpub-zz

### Robustness (ROB)
- Cope with fields with upside down box/rectangle (#2729) by @pubpub-zz

### Documentation (DOC)
- Update Link Documentation Example (#2759) by @jparris
- Make table consistent with pdf-version-support.md (#2758) by @j-t-1
- Add feature support by pypdf (#2738) by @j-t-1
- Move JavaScript example (#2746) by @j-t-1
- Added example for downloading a PDF from Google Cloud Storage  (#2745) by @prodeveloper
- Miscellaneous tiny changes (#2744) by @j-t-1
- Amend comment with rectangle duplication (#2733) by @j-t-1
- Use enumerate in extract example (#2727) by @j-t-1
- Tiny changes (#2723) by @j-t-1

### Maintenance (MAINT)
- Remove redundant pass statement (#2739) by @j-t-1
- Update Python version support documentation (#2740) by @j-t-1
- Remove redundant super() (#2734) by @j-t-1
- Add deprecate_with_replacement to StreamObject.initializeFromDictionary (#2728) by @j-t-1
- Deal with cryptography>=43 moving ARC4 (#2765) by @MartinThoma

### Code Style (STY)
- Change argument type (#2741) by @j-t-1
- Use endswith instead of logical equals (#2732) by @j-t-1

[Full Changelog](4.3.0...4.3.1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants