Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: Remove .flake8 #2895

Merged
merged 2 commits into from
Oct 8, 2024
Merged

DEV: Remove .flake8 #2895

merged 2 commits into from
Oct 8, 2024

Conversation

j-t-1
Copy link
Contributor

@j-t-1 j-t-1 commented Oct 8, 2024

Also sort the ignore list.

Also sort the ignore list.
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.43%. Comparing base (8245fbc) to head (5ce98b4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2895   +/-   ##
=======================================
  Coverage   96.43%   96.43%           
=======================================
  Files          52       52           
  Lines        8726     8726           
  Branches     1721     1721           
=======================================
  Hits         8415     8415           
  Misses        182      182           
  Partials      129      129           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefan6419846
Copy link
Collaborator

The exclude should not hurt IMHO. Nevertheless, the file should be unused after #2572 and could probably be removed completely.

pypdf moved from flake8 to ruff. This is a continuation of py-pdf#2572.
@j-t-1 j-t-1 changed the title MAINT: Remove tox from .flake8 DEV: Remove .flake8 Oct 8, 2024
@j-t-1
Copy link
Contributor Author

j-t-1 commented Oct 8, 2024

Deleted the file. Feel free to change the commit message, which is now:

pypdf moved from flake8 to ruff. This is a continuation of #2572.

@stefan6419846 stefan6419846 merged commit a7d5c8d into py-pdf:main Oct 8, 2024
17 checks passed
@j-t-1 j-t-1 deleted the flake8 branch October 8, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants